Steps to reproduce:

  1. Create a new term
  2. Click 'edit' from the term list page
  3. Click the 'Delete' link in the bottom right hand corner
  4. Expected to be taken to the confirm delete page
  5. Was taken back to the term listing page and the term was not deleted
Files: 
CommentFileSizeAuthor
#18 Screenshot (6).png90.47 KBShreya Shetty
#18 Screenshot (5).png82.26 KBShreya Shetty
#18 Screenshot (2).png86.98 KBShreya Shetty
#9 2069411-term-delete-test-only-9-FAIL.patch868 byteskim.pepper
FAILED: [[SimpleTest]]: [MySQL] 59,250 pass(es), 3 fail(s), and 1 exception(s).
[ View ]
#9 2069411-term-delete-9-PASS.patch1.68 KBkim.pepper
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 2069411-term-delete-9-PASS.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#9 interdiff.txt1.53 KBkim.pepper
#6 patch-2069411-5.patch850 bytesTimVS
PASSED: [[SimpleTest]]: [MySQL] 58,952 pass(es).
[ View ]
#5 patch-2069411-5.patch850 bytesTimVS
PASSED: [[SimpleTest]]: [MySQL] 58,637 pass(es).
[ View ]

Comments

kim.pepper’s picture

tim.plunkett’s picture

This is actually different from the other issue, but it needs similar test coverage.

TermFormController::delete() sets the redirect, but the destination seems to override it. Not 100% sure what's going on there.

-enzo-’s picture

Status:Active» Closed (works as designed)
kim.pepper’s picture

Status:Closed (works as designed)» Active

This does not work as designed. A term still cannot be deleted from the term edit form.

TimVS’s picture

Status:Active» Needs review
StatusFileSize
new850 bytes
PASSED: [[SimpleTest]]: [MySQL] 58,637 pass(es).
[ View ]

I wrote a patch.
The problem was that the destination wasn't removed.

TimVS’s picture

StatusFileSize
new850 bytes
PASSED: [[SimpleTest]]: [MySQL] 58,952 pass(es).
[ View ]

Double post due to the network

swentel’s picture

Status:Needs review» Needs work
Issue tags:+Needs tests

Patch works, but we need tests for this.

kim.pepper’s picture

Assigned:Unassigned» kim.pepper
kim.pepper’s picture

Status:Needs work» Needs review
StatusFileSize
new1.53 KB
new1.68 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 2069411-term-delete-9-PASS.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
new868 bytes
FAILED: [[SimpleTest]]: [MySQL] 59,250 pass(es), 3 fail(s), and 1 exception(s).
[ View ]

The tests are currently passing because there is no 'destination' query string param being passed. Once you pass one in, it should fail.

The last submitted patch, 2069411-term-delete-9-PASS.patch, failed testing.

kim.pepper’s picture

Status:Needs work» Needs review
Issue tags:+Needs tests

#9: 2069411-term-delete-9-PASS.patch queued for re-testing.

swentel’s picture

Status:Needs review» Reviewed & tested by the community
Issue tags:-Needs tests

Cool, thanks!

Bojhan’s picture

Just an FYI. As far I know, this button shouldn't even be there.

Dries’s picture

But why does the destination overwrite things? Not sure I understand why it needs to be unset.

Xano’s picture

9: 2069411-term-delete-9-PASS.patch queued for re-testing.

Xano’s picture

9: 2069411-term-delete-9-PASS.patch queued for re-testing.

Status:Reviewed & tested by the community» Needs work

The last submitted patch, 9: 2069411-term-delete-9-PASS.patch, failed testing.

Shreya Shetty’s picture

Issue summary:View changes
StatusFileSize
new86.98 KB
new82.26 KB
new90.47 KB

This issue wherein the delete link works as expected.I have some screenshots attached.

Shreya Shetty’s picture

Status:Needs work» Closed (works as designed)