There is a typo in file drupal\core\modules\views\lib\Drupal\views\Tests\Plugin\StyleTest.php:
$this->assertEqual($sets_new_rendered, $expected, 'The style plugins should proper group the results with grouping by the rendered output.');

CommentFileSizeAuthor
#4 2068219-2.patch962 bytesbalagan
#1 2068219.patch962 bytesbalagan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

balagan’s picture

balagan CreditAttribution: balagan commented
Status: Active » Needs review
FileSize
2068219.patch962 bytes

Enclosed the patch for the corrected version.

Status: Needs review » Needs work

The last submitted patch, 2068219.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Issue tags: +VDC

+1 for the change in general. You might need to make another rerole.

balagan’s picture

balagan CreditAttribution: balagan commented
Version: 8.0-alpha2 » 8.x-dev
FileSize
2068219-2.patch962 bytes

Trying again with 8.x-dev now.

balagan’s picture

balagan CreditAttribution: balagan commented
Status: Needs work » Needs review
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Reviewed & tested by the community

Cool!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Nice find!

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.