Part of meta-issue #2002650: [meta, no patch] improve maintainability by removing unused local variables

File /core/modules/node/lib/Drupal/node/Tests/NodeTranslationUITest.php

Line 120: Unused local variable $index
Line 189: Unused local variable $disabledNode

CommentFileSizeAuthor
#1 2067993-remove-unused-local-variable-index-and-disableNode-1.patch1.42 KBrhm5000
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rhm5000’s picture

rhm5000 CreditAttribution: rhm5000 commented
Status: Active » Needs review
FileSize
2067993-remove-unused-local-variable-index-and-disableNode-1.patch1.42 KB
LinL’s picture

LinL CreditAttribution: LinL commented

This a duplicate of #2080059: Remove Unused local variable $index from /core/modules/node/lib/Drupal/node/Tests/NodeTranslationUITest.php.

The other issue has a different solution. Not sure which is better, so not closing either as a duplicate just yet.

LinL’s picture

LinL CreditAttribution: LinL commented
Status: Needs review » Reviewed & tested by the community

Patch still applies, the deleted variables are not used. RTBC.

And thanks to mcrittenden on the other issue.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.