Remove Unused local variable $alias from /core/modules/views/lib/Drupal/views/ManyToOneHelper.php

@jlindsey15 Yes after looking at the code:

$alias = $this->handler->tableAliases[$value] = $this->addTable($join, $this->handler->view->many_to_one_aliases[$field][$value]);

          // and set table_alias to the first of these.
          if (empty($this->handler->tableAlias)) {
            $this->handler->tableAlias = $alias;
          }

local variable $alias is not unused.

It seems like $this->handler->tableAliases always gets one value on this line,

$alias = $this->handler->tableAliases[$value] = $this->addTable($join, $this->handler->view->many_to_one_aliases[$field][$value]);

causing the conditional if (empty($this->handler->tableAlias)) to always return FALSE.

as a result, the variable $alias seems to be unused.

In addition in the case $this->handler->tableAliases is empty, $alias must be empty too, $alias is equal to an item in $this->handler->tableAliases

@alexanderpas The conditional if (empty($this->handler->tableAlias)) is checking $this->handler->tableAlias not $this->handler->tableAliases, thus if (empty($this->handler->tableAlias)) can return True. I agree if $this->handler->tableAliases is empty, $alias must be empty, meaning $this->handler->tableAlias = $alias; could return empty causing the conditional if (empty($this->handler->tableAlias)) to be insufficient or wrong conditional.

I have also changed comment to drupal code standards.

The code style looks fine, and the patch applies.

+++ b/core/modules/views/lib/Drupal/views/ManyToOneHelper.php
@@ -220,11 +220,11 @@ public function ensureMyTable() {
+          $this->handler->tableAliases[$value] = $this->addTable($join, $this->handler->view->many_to_one_aliases[$field][$value]);
+          // And set table_alias to the first of these.
           if (empty($this->handler->tableAlias)) {
-            $this->handler->tableAlias = $alias;
+            $this->handler->tableAlias = $this->handler->tableAliases[$value];
           }

Let's fix up the comment here too.. No need to start with "And" and we are not longer setting table_alias

Back to RTBC.

10: views-2067529-10.patch queued for re-testing.

10: views-2067529-10.patch queued for re-testing.

Committed and pushed to 8.x. Thanks!