Drupal.editors.ckeditor.attachInlineEditor() should pass Drupal-specific settings like Drupal.editors.ckeditor.attach() does [#2067427]

#1879120: Use Drupal-specific image and link plugins — use core dialogs rather than CKEditor dialogs, containing alterable Drupal forms (commit) introduced the automatic ckeditorConfig.drupal.format setting to contain the machine name of the text format. However, we only did this for Drupal.editors.ckeditor.attach(), not for Drupal.editors.ckeditor.attachInlineEditor(). This can cause problems.

Comment	File	Size	Author
#1	ckeditor_drupal_specfic_settings_inline-2067427-1.patch	728 bytes	wim leers

Comments

Comment #1

wim leers

Ghent 🇧🇪🇪🇺

commented 16 August 2013 at 19:26

Status:

Active

» Reviewed & tested by the community

Status	File	Size
new	ckeditor_drupal_specfic_settings_inline-2067427-1.patch	728 bytes

Attached patch brings attachInlineEditor() in line with attach():

  attach: function (element, format) {
    this._loadExternalPlugins(format);
    this._ACF_HACK_to_support_blacklisted_attributes(element, format);
    // Also pass settings that are Drupal-specific.
    format.editorSettings.drupal = {
      format: format.format
    };
    return !!CKEDITOR.replace(element, format.editorSettings);
  },

I don't like RTBC'ing my own patches. But, given that quicksketch has stepped down and this is an extremely trivial patch, I think nobody else would RTBC it…