Problem/Motivation

LocalActionManager does not cache plugin definitions, so they are rebuilt on every request.

Proposed resolution

Add caching! The DefaultPluginManager supports this, we just need to call setCacheBackend().

Remaining tasks

Patch.

User interface changes

None

API changes

None

CommentFileSizeAuthor
d8.localActionManager-cache.patch2.45 KBdamiankloip

Comments

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Reviewed & tested by the community

Makes sense, let's do this. This adds more cache queries to every request, but that's better than parsing yaml files and annotations.

#2064511: Use a cache collector to combine related plugin caches is an idea to reduce the amount of cache queries.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Assigned: Unassigned » catch

Looks sane to me, but tossing to catch for confirmation.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Yep. Committed/pushed to 8x., thanks!

dawehner’s picture

dawehner
Primary language German
commented

Damian!!! #2046565: Cache the local action plugins that appear per route

damiankloip’s picture

damiankloip commented

Ohhh, sorry :( I didn't realise that patch added definition caching too!

dawehner’s picture

dawehner
Primary language German
commented

That is okay, all you have to do is to review both local actions and local tasks caching :p

damiankloip’s picture

damiankloip commented

You have me, I will. Tomorrow!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.