Part of meta-issue #2002650: [meta, no patch] improve maintainability by removing unused local variables

File /core/modules/views/views.tokens.inc

Line 77: Unused local variable $langcode

CommentFileSizeAuthor
#2 drupal-2065115-1.patch514 bytessergeypavlenko
#1 drupal8.other_.2065115-1.patch0 bytessergeypavlenko
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sergeypavlenko’s picture

sergeypavlenko CreditAttribution: sergeypavlenko commented
Assigned: sergeypavlenko » Unassigned
Status: Active » Needs review
FileSize
drupal8.other_.2065115-1.patch0 bytes
sergeypavlenko’s picture

sergeypavlenko CreditAttribution: sergeypavlenko commented
FileSize
drupal-2065115-1.patch514 bytes
victor-shelepen’s picture

victor-shelepen CreditAttribution: victor-shelepen commented
Status: Needs review » Needs work

It is the empty patch file.

victor-shelepen’s picture

victor-shelepen CreditAttribution: victor-shelepen commented
Status: Needs work » Needs review

Sorry. I am wrong.

victor-shelepen’s picture

victor-shelepen CreditAttribution: victor-shelepen commented
Status: Needs review » Reviewed & tested by the community

Yes. The variable $language is unused.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Component: other » views.module
Status: Reviewed & tested by the community » Needs review
Issue tags: +VDC

Wonder if this is an oversight, though... Should that $langcode variable actually be getting passed into some of the code below?

Moving components and tagging VDC.

sergeypavlenko’s picture

sergeypavlenko CreditAttribution: sergeypavlenko commented

The variable $langcode below in the code is not used. I think it should be removed.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented

Yes, I realize that. I'm asking whether that's actually a bug. :)

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

I am not sure but can you actually translate something of description/label(admin)/title ... of a view?

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Status: Needs review » Reviewed & tested by the community

Suppose we should get rid of all unused variables, as I know views uses config translation now

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

ok cool, just checking.

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.