In testing out http://drupal.org/node/153998, I tried the following experiment:

1. Enable all Drupal core modules in 5.x.
2. Enable all possible permissions for a particular role.
3. Upgrade to Drupal 6.x.

In doing so, I found that some permissions were mysteriously removed for no apparent reason.

One is the "edit any book content" permission (formerly known as "edit book content" in 5.x), which was due to a simple mistake in book.install... this is fixed in the attached patch.

The other is the "administer locales" permission in 5.x. It looks like it's been split up into two permissions in 6.x ("administer languages" and "translate interface"), but nothing gets changed on the DB update so neither of these get enabled. I would think both of these should get enabled for any role that previously had "adminster locales", but I may be wrong about this because I don't know much about the new language system... For now I haven't included it in the attached patch. Suggestions from anyone who knows more about this are welcome... thanks.

CommentFileSizeAuthor
restore_book_permissions.patch762 bytesDavid_Rothstein
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

catch’s picture

Just realised you're the same person as on the other issue so no need to cross link :)

We'll also need an upgrade path from rc1 - rc2. Leaving at CNR, since the other issue is likely to have a database update anyway, could possibly merge this into that.

pwolanin’s picture

looks like someone missed the book module when they changed the permission names

catch’s picture

Actually it looks like a hunk didn't get committed from the final patch here: http://drupal.org/node/120960#new

pwolanin’s picture

Status: Needs review » Reviewed & tested by the community

how the hell do hunks of patches get missed?! This is about the 3rd time in the last couple weeks.

Dries’s picture

Status: Reviewed & tested by the community » Needs work

I've committed this patch; while that fixes the book permission, we might still want to look at the other permissions?

pwolanin’s picture

@Dries - I took a quick look through the original patch, and seemed like the poll module changes got in correctly.

Gábor Hojtsy’s picture

Status: Needs work » Active

Yes, both locale permissions can be given to those who had the previous permission. Seems like that one is missing here.

Gábor Hojtsy’s picture

Status: Active » Fixed

Merged the remaining RC1 - RC2 update of the book permissions and the locale update to http://drupal.org/node/153998 so marking this fixed for the earlier committed patch.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.