Part of meta-issue #2002650: [meta, no patch] improve maintainability by removing unused local variables

File /core/modules/node/node.pages.inc

Line 56: Unused local variable $output
Line 214: Unused local variable $type

CommentFileSizeAuthor
#1 drupal-2062581-1.patch654 bytessergeypavlenko

Comments

sergeypavlenko’s picture

sergeypavlenko commented
Assigned: sergeypavlenko » Unassigned
Status: Active » Needs review
StatusFileSize
new drupal-2062581-1.patch654 bytes

Status: Needs review » Needs work
Issue tags: -Novice, -CodeSprintCIS

The last submitted patch, drupal-2062581-1.patch, failed testing.

sergeypavlenko’s picture

sergeypavlenko commented
Status: Needs work » Needs review
Issue tags: +Novice, +CodeSprintCIS

#1: drupal-2062581-1.patch queued for re-testing.

andymartha’s picture

andymartha commented
Status: Needs review » Reviewed & tested by the community

After applying the patch drupal-2062581-1.patch by sergeypavlenko in #1 to a Drupal 8 fresh install 8/12, the patch applied cleanly and removed the two unused variables from the file! Anything else, just ask.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Component: node system » node.module
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.