On many of the fieldset titles in the Views forms (probably all, but I didn't look at all of them), there is a large amount of excess space between them and the border of the box above them.

space-above-titles.png

The attached patch fixes the problem.

CommentFileSizeAuthor
#2 space-above-titles-after.png5.8 KBoadaeh
space-above-titles.png6.08 KBoadaeh
remove-excess-space-above-views-fieldset-titles.patch478 bytesoadaeh
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Category: task » bug

Thank for working on that. This indeed looks really ugly!

You should better also provide a picture after it. Did you had a look at bartik/stark how it looks in these themes?

oadaeh’s picture

oadaeh CreditAttribution: oadaeh commented
FileSize
space-above-titles-after.png5.8 KB

The appearance of the fieldset titles are fine in the other two themes. It is only in Seven that any change needs to be made.

Here is the after screen shot:
space-above-titles-after.png

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Reviewed & tested by the community

Great, thank you!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Wow, less code and a nicer-looking listing. Well done! :)

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.