Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
other
Priority:
Minor
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
10 Aug 2013 at 14:48 UTC
Updated:
29 Jul 2014 at 22:45 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
duozerskNot sure if we can somehow fix the $source variable. The patch only fixes the $original_path.
AndyB
Comment #2
andypostSure,
$sourceneeded here, because could not be defined as used in second part of conditionPS: phpstorm could be wrong, I've filed issue to their tracker WI-19665
Comment #3
alexpottNope phpstorm is not wrong
$sourceis always defined again by the second part of the if statement as this will always be executed because the condition is an OR.To be honest I think the code would be more readable if the was this
Comment #4
duozerskWill do.
Comment #5
duozerskComment #7
duozerskYep, I should think more when following the advices ;)
Comment #8
andypostMuch more readable
Comment #9
duozerskComment #10
webchickGreat job!
Committed and pushed to 8.x. Thanks!