Part of meta-issue #2002650: [meta, no patch] improve maintainability by removing unused local variables

File /core/lib/Drupal/Core/Config/Entity/Query/Condition.php

Line 110: Unused local variable $candidates

CommentFileSizeAuthor
#1 drupal-remove-unused-var-2062225-1.patch621 bytesduozersk

Comments

duozersk’s picture

duozersk
he/him
Primary language Russian
Location Moscow
commented
Assigned: duozersk » Unassigned
Status: Active » Needs review
StatusFileSize
new drupal-remove-unused-var-2062225-1.patch621 bytes

Status: Needs review » Needs work
Issue tags: -Novice, -CodeSprintCIS

The last submitted patch, drupal-remove-unused-var-2062225-1.patch, failed testing.

duozersk’s picture

duozersk
he/him
Primary language Russian
Location Moscow
commented
Status: Needs work » Needs review
Issue tags: +Novice, +CodeSprintCIS

#1: drupal-remove-unused-var-2062225-1.patch queued for re-testing.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Reviewed & tested by the community

yep, they are defined in if or in else

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed bcbc4a0 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.