Replace user_access() calls with $account->hasPermission() in taxonomy module [#2062027]

Let's start to convert all calls to user_access() with the new AccountInterface::hasPermission() method.

Part of #2048171: [meta] Replace user_access() calls with $account->hasPermission() wherever possible.

Change records for this issue:

user_access() got converted to a method on the user/accountInterface

Comment	File	Size	Author
#1	drupal-taxonomy_replace_user_access-2062027.patch	2.56 KB	InternetDevels
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

InternetDevels CreditAttribution: InternetDevels commented 10 August 2013 at 11:58

File	Size
drupal-taxonomy_replace_user_access-2062027.patch	2.56 KB

Patch attached.

Comment #2

InternetDevels CreditAttribution: InternetDevels commented 10 August 2013 at 11:59

Status:

Active

» Needs review

Forgot to change status.

Comment #3

andypost

he/him

Russian

CreditAttribution: andypost commented 27 August 2013 at 20:06

#1: drupal-taxonomy_replace_user_access-2062027.patch queued for re-testing.

Comment #4

andypost

he/him

Russian

CreditAttribution: andypost commented 27 August 2013 at 20:07

Status:

Needs review

» Reviewed & tested by the community

If bot green

$ git grep user_access core/modules/taxonomy/
core/modules/taxonomy/lib/Drupal/taxonomy/TermAccessController.php:27:        return user_access('access content', $account);
core/modules/taxonomy/lib/Drupal/taxonomy/TermAccessController.php:31:        return user_access("edit terms in {$entity->bundle()}", $account) || user_access('a
core/modules/taxonomy/lib/Drupal/taxonomy/TermAccessController.php:35:        return user_access("delete terms in {$entity->bundle()}", $account) || user_access(
core/modules/taxonomy/lib/Drupal/taxonomy/TermAccessController.php:44:    return user_access('administer taxonomy', $account);
core/modules/taxonomy/lib/Drupal/taxonomy/VocabularyAccessController.php:25:    return user_access('administer taxonomy', $account);
core/modules/taxonomy/lib/Drupal/taxonomy/VocabularyAccessController.php:32:    return user_access('administer taxonomy', $account);