Let's start to convert all calls to user_access() with the new AccountInterface::hasPermission() method.

Part of #2048171: [meta] Replace user_access() calls with $account->hasPermission() wherever possible.

Change records for this issue:

CommentFileSizeAuthor
#1 drupal-taxonomy_replace_user_access-2062027.patch2.56 KBinternetdevels

Comments

internetdevels’s picture

internetdevels commented
StatusFileSize
new drupal-taxonomy_replace_user_access-2062027.patch2.56 KB

Patch attached.

internetdevels’s picture

internetdevels commented
Status: Active » Needs review

Forgot to change status.

andypost’s picture

andypost
he/him
Primary language Russian
commented

#1: drupal-taxonomy_replace_user_access-2062027.patch queued for re-testing.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Reviewed & tested by the community

If bot green

$ git grep user_access core/modules/taxonomy/
core/modules/taxonomy/lib/Drupal/taxonomy/TermAccessController.php:27:        return user_access('access content', $account);
core/modules/taxonomy/lib/Drupal/taxonomy/TermAccessController.php:31:        return user_access("edit terms in {$entity->bundle()}", $account) || user_access('a
core/modules/taxonomy/lib/Drupal/taxonomy/TermAccessController.php:35:        return user_access("delete terms in {$entity->bundle()}", $account) || user_access(
core/modules/taxonomy/lib/Drupal/taxonomy/TermAccessController.php:44:    return user_access('administer taxonomy', $account);
core/modules/taxonomy/lib/Drupal/taxonomy/VocabularyAccessController.php:25:    return user_access('administer taxonomy', $account);
core/modules/taxonomy/lib/Drupal/taxonomy/VocabularyAccessController.php:32:    return user_access('administer taxonomy', $account);
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.