Let's start to convert all calls to user_access() with the new AccountInterface::hasPermission() method.

Part of #2048171: [meta] Replace user_access() calls with $account->hasPermission() wherever possible.

Change records for this issue:

CommentFileSizeAuthor
#4 drupal-path_replace_user_access-2062011-4.patch1.82 KBalbert volkman
#4 interdiff.txt1006 bytesalbert volkman
#1 drupal-path_replace_user_access-2062011.patch1.9 KBinternetdevels

Comments

internetdevels’s picture

internetdevels commented
Status: Active » Needs review
StatusFileSize
new drupal-path_replace_user_access-2062011.patch1.9 KB

Here is the patch.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Needs work
Issue tags: +Needs reroll

Does not applies

+++ b/core/modules/path/path.module
@@ -116,6 +116,7 @@ function path_form_node_form_alter(&$form, $form_state) {
+  $account = Drupal::request()->attributes->get('_account');

@@ -230,6 +231,7 @@ function path_node_predelete(EntityInterface $node) {
+  $account = Drupal::request()->attributes->get('_account');

Should use Drupal::currentUser() service

andypost’s picture

andypost
he/him
Primary language Russian
commented
Component: user system » path.module
albert volkman’s picture

albert volkman commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt1006 bytes
new drupal-path_replace_user_access-2062011-4.patch1.82 KB

Re-rolled and applied suggestion from #2.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs reroll

Great! all fixed now

$ git grep user_access core/modules/path/
core/modules/path/path.module:128:    '#access' => user_access('create url aliases') || user_access('administer url aliases'),
core/modules/path/path.module:200:      '#access' => user_access('create url aliases') || user_access('administer url aliases'),
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.