Let's start to convert all calls to user_access() with the new AccountInterface::hasPermission() method.

Part of #2048171: [meta] Replace user_access() calls with $account->hasPermission() wherever possible.

Change records for this issue:

CommentFileSizeAuthor
#5 drupal-overlay_replace_user_access-2062009-5.patch2.63 KBinternetdevels
#5 interdiff.txt1.38 KBinternetdevels
#1 drupal-overlay_replace_user_access-2062009.patch2.8 KBinternetdevels

Comments

internetdevels’s picture

internetdevels commented
Status: Active » Needs review
StatusFileSize
new drupal-overlay_replace_user_access-2062009.patch2.8 KB

Patch attached.

Status: Needs review » Needs work
Issue tags: -CodeSprintCIS

The last submitted patch, drupal-overlay_replace_user_access-2062009.patch, failed testing.

internetdevels’s picture

internetdevels commented
Status: Needs work » Needs review

#1: drupal-overlay_replace_user_access-2062009.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +CodeSprintCIS

The last submitted patch, drupal-overlay_replace_user_access-2062009.patch, failed testing.

internetdevels’s picture

internetdevels commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt1.38 KB
new drupal-overlay_replace_user_access-2062009-5.patch2.63 KB

One more try.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Reviewed & tested by the community

Still applies cleanly, all 4 fixed git grep user_access core/modules/overlay/

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.