#2047951: [META] Remove calls to deprecated global $user and $GLOBALS['user']
remove:

function _toolbar_get_subtree_hash() {
  global $user;
CommentFileSizeAuthor
#10 toolbar-remove_calls_to_deprecated_global_user-2061897-10.patch559 bytesorb
#8 toolbar-remove_calls_to_deprecated_global_user-2061897-7.patch584 bytesorb
#7 toolbar-remove_calls_to_deprecated_global_user-2061897-6.patch584 bytesorb
#5 toolbar-remove_calls_to_deprecated_global_user-2061897-5.patch665 bytesorb
#4 toolbar-remove_calls_to_deprecated_global_user-2061897-4.patch666 bytesorb
#2 toolbar-remove_calls_to_deprecated_global_user-2061897-2.patch656 bytesorb

Comments

orb’s picture

orb commented
Title: Remove calls to deprecated global $user » Remove calls to deprecated global $user in toolbar module
Status: Needs work » Active
orb’s picture

orb commented
Assigned: orb » Unassigned
Status: Active » Needs review
StatusFileSize
new toolbar-remove_calls_to_deprecated_global_user-2061897-2.patch656 bytes

fix

orb’s picture

orb commented

sorry, wrong file

orb’s picture

orb commented
StatusFileSize
new toolbar-remove_calls_to_deprecated_global_user-2061897-4.patch666 bytes

fix

orb’s picture

orb commented
StatusFileSize
new toolbar-remove_calls_to_deprecated_global_user-2061897-5.patch665 bytes

Delete \ for function

Status: Needs review » Needs work

The last submitted patch, toolbar-remove_calls_to_deprecated_global_user-2061897-5.patch, failed testing.

orb’s picture

orb commented
Status: Needs work » Needs review
StatusFileSize
new toolbar-remove_calls_to_deprecated_global_user-2061897-6.patch584 bytes

Fix - delete $acconut

orb’s picture

orb commented
StatusFileSize
new toolbar-remove_calls_to_deprecated_global_user-2061897-7.patch584 bytes

Fix $user

Status: Needs review » Needs work

The last submitted patch, toolbar-remove_calls_to_deprecated_global_user-2061897-7.patch, failed testing.

orb’s picture

orb commented
StatusFileSize
new toolbar-remove_calls_to_deprecated_global_user-2061897-10.patch559 bytes

Issue #2062151: Create a current user service to ensure that current account is always available

orb’s picture

orb commented
Status: Needs work » Needs review
sergeypavlenko’s picture

sergeypavlenko commented

Nice.

sergeypavlenko’s picture

sergeypavlenko commented
Status: Needs review » Reviewed & tested by the community

All is well. Change the status.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 6454dbe and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.