API page: https://api.drupal.org/api/drupal/modules%21system%21system.api.php/func...

Page says:
'worker callback': The name of the function to call. It will be called with one argument, the item created via DrupalQueue::createItem() in hook_cron().

However DrupalQueue::createItem() could be called anywhere, not only in hook_cron(). I suggest to remove the last two words from the paragraph.

CommentFileSizeAuthor
#11 hook_cron_queue_info-2061275-11.patch725 bytesstephaneq
#7 hook_queue_info-2061275-7.patch772 bytesstephaneq
#7 hook_queue_info-2061275-7.interdiff.txt782 bytesstephaneq
#4 hook_queue_info-2061275-4.patch1.06 KBstephaneq
#4 hook_queue_info-2061275-4.interdiff.txt1.04 KBstephaneq
#2 hook_queue_info-2061275-2.patch771 bytesstephaneq

Comments

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Version: 7.x-dev » 8.x-dev
Issue tags: +Novice, +Needs backport to D7

Good idea!

This documentation fix needs to first be applied to hook_queue_info() in drupal 8 (the new name of the hook) and then backported to Drupal 7.
https://api.drupal.org/api/drupal/core!modules!system!system.api.php/fun...

stephaneq’s picture

stephaneq
Primary language French
Location Paris 🇫🇷
commented
Status: Active » Needs review
StatusFileSize
new hook_queue_info-2061275-2.patch771 bytes

Here is the D8 patch

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Needs work

Thanks! While you're at it, could you fix another error in that same line of documentation? All namespaces in documentation should start with \

Sigh. As a bonus you could also fix the indentation on the list:
https://drupal.org/node/1354#lists

stephaneq’s picture

stephaneq
Primary language French
Location Paris 🇫🇷
commented
StatusFileSize
new hook_queue_info-2061275-4.interdiff.txt1.04 KB
new hook_queue_info-2061275-4.patch1.06 KB

I'm not sure about the indentation fix, but well...

stephaneq’s picture

stephaneq
Primary language French
Location Paris 🇫🇷
commented
Status: Needs work » Needs review
jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Needs work

Oh. Indentation - my mistake. Can you put it back the way it was? The other fix is right.

stephaneq’s picture

stephaneq
Primary language French
Location Paris 🇫🇷
commented
Status: Needs work » Needs review
StatusFileSize
new hook_queue_info-2061275-7.interdiff.txt782 bytes
new hook_queue_info-2061275-7.patch772 bytes
jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Thanks!

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to 8.x. Thanks.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Version: 8.x-dev » 7.x-dev
Status: Fixed » Patch (to be ported)

Needs backport.

stephaneq’s picture

stephaneq
Primary language French
Location Paris 🇫🇷
commented
StatusFileSize
new hook_cron_queue_info-2061275-11.patch725 bytes

D7 patch

stephaneq’s picture

stephaneq
Primary language French
Location Paris 🇫🇷
commented
Status: Patch (to be ported) » Needs review

Status: Needs review » Needs work
Issue tags: -Novice, -Needs backport to D7

The last submitted patch, hook_cron_queue_info-2061275-11.patch, failed testing.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs work » Needs review

#11: hook_cron_queue_info-2061275-11.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, hook_cron_queue_info-2061275-11.patch, failed testing.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs work » Needs review
Issue tags: +Novice, +Needs backport to D7

#11: hook_cron_queue_info-2061275-11.patch queued for re-testing.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

I don't know what all those failing tests were about ?!?. Ready to go now. Thanks!

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Thanks! Committed to 7.x.

Automatically closed -- issue fixed for 2 weeks with no activity.