Part of meta-issue #2002650: [meta, no patch] improve maintainability by removing unused local variables

File /core/lib/Drupal/Core/Database/Query/Select.php

Line 632: Unused local variable $alias
Line 686: Unused local variable $alias
Line 691: Unused local variable $alias
Line 699: Unused local variable $alias

CommentFileSizeAuthor
#1 core-remove-unused-local-variables-select.php-2060821-1.patch1.77 KBlegolasbo

Comments

legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
commented
Status: Active » Needs review
StatusFileSize
new core-remove-unused-local-variables-select.php-2060821-1.patch1.77 KB

Attached patch removes the unused variables

Status: Needs review » Needs work
Issue tags: -Novice

The last submitted patch, core-remove-unused-local-variables-select.php-2060821-1.patch, failed testing.

legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
commented
Status: Needs work » Needs review
Issue tags: +Novice

#1: core-remove-unused-local-variables-select.php-2060821-1.patch queued for re-testing.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Checked all the instances and they are indeed unused.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Component: other » database system
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
commented
Assigned: legolasbo » Unassigned

Automatically closed -- issue fixed for 2 weeks with no activity.