Closed (fixed)
Project:
Tour UI
Version:
8.x-1.0-beta1
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
8 Aug 2013 at 11:37 UTC
Updated:
30 Sep 2018 at 14:08 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
clemens.tolboomComment #2
nick_schuch commentedTour's for Tour UI! haha. Nice!
Assigning to me for review.
Comment #3
clemens.tolboomAttached patch are loadable through http://drupal.d8/admin/config/development/configuration/single/import but they are not loaded after uninstall and install the Tour UI module.
What is wrong with that?
Comment #4
mpp commentedHow come there's a patch open for creating tours when there are already tours in dev?
Comment #5
clemens.tolboomComment #6
clemens.tolboom@mpp I guess you refer to https://cgit.drupalcode.org/tour_ui/tree/config
Comment #7
mpp commentedIndeed, the patch in #3 already seems to be committed?
I can provide some feedback but should I do it on the patch in #3 or on dev or am I missing something?
Comment #8
clemens.tolboom@mpp please test whether DEV still works. My guess is those tours are not working due to tour structure / change records.
Probably patch #3 is same to latest DEV. But are they? That must be checked.
Checking commit files those came with #2025867: We should add an input format to the text tip body.
Comment #9
clemens.tolboomI just installed latest DEV
- http://drupal.d8/admin/help ... no Tour UI in the list of tours
- http://drupal.d8/admin/config/user-interface/tour ... no Tour Icon
- http://drupal.d8/admin/structure/views/view/frontpage ... WITH Tour Icon
- http://drupal.d8/admin/config/development/configuration/single/import I can import modules/tour_ui/config/tour.tour.tour-edit.yml which is then listed on http://drupal.d8/admin/help
- http://drupal.d8/admin/config/user-interface/tour/manage/tour-edit has now a Tour
- http://drupal.d8/admin/config/user-interface/tour/manage/tip-edit/tip/ed... has a Tour
So why are the new tours still not imported automatically?
Comment #11
clemens.tolboomI'm so used to gitlab/hub I committed the fix for the above problem.
https://www.drupal.org/commitlog/commit/50862/10924014540991c29899805679...
@mpp hope I didn't wasted your time.
Feel free to reopen.
Comment #12
clemens.tolboomI should have checked the patch from #3 against latest head.
Comment #13
clemens.tolboomPatch from #3 are same as files in DEV. Pfew
Comment #14
mpp commented:-) tbh I can't wait until we have gitlab. These patch files are so archaic...
I'll open an issue/PR on github with my feedback.
Comment #15
clemens.tolboom@mpp this issue is now fixed :-) so no actions are needed.
Comment #16
clemens.tolboom