I've installed past. The following modules are enabled: past, past log grabber, past database backend.
whenever I check "Log watchdog to past event log" on the module options, I can see the messages logged on the past event log, but
I get the following error on function _past_error_array_to_event():

Notice: Undefined index: %type in sites/all/modules/past/past.module on line 322 
Notice: Undefined index: %function in sites/all/modules/past/past.module on line 323 
Notice: Undefined index: %file in sites/all/modules/past/past.module on line 324 
Notice: Undefined index: %line in sites/all/modules/past/past.module on line 324 
Notice: Undefined index: severity_level in sites/all/modules/past/past.module on line 325

Putting dsm($error) inside the function shows that $error is an empty array.

The errors are printed on the top of EVERY page on the site. They are printed even when no PHP error logging is off.

Otherwise it works great!

CommentFileSizeAuthor
#9 php_errors_notices-2060169-9-testonly.patch561 bytess_leu
#9 php_errors_notices-2060169-9.patch2.03 KBs_leu
#9 php_errors_notices-2060169-9-interdiff.txt362 bytess_leu
#7 php_errors_notices-2060169-7-interdiff.txt588 bytess_leu
#7 php_errors_notices-2060169-7.patch2.06 KBs_leu
#2 php_errors_notices-2060169-2.patch1.48 KBs_leu

Comments

druvision’s picture

druvision commented
Issue summary: View changes

Otherwise it works great

druvision’s picture

druvision commented
Priority: Normal » Major
s_leu’s picture

s_leu commented
Status: Active » Needs review
StatusFileSize
new php_errors_notices-2060169-2.patch1.48 KB

Was able to reproduce it, here's a patch for it

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Issue tags: +Needs tests

A test would be pretty easy to implement here, let's add one.

Status: Needs review » Needs work
Issue tags: -Needs tests

The last submitted patch, php_errors_notices-2060169-2.patch, failed testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Needs review
Issue tags: +Needs tests

#2: php_errors_notices-2060169-2.patch queued for re-testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Needs work

Missing a test :)

s_leu’s picture

s_leu commented
Status: Needs work » Needs review
StatusFileSize
new php_errors_notices-2060169-7.patch2.06 KB
new php_errors_notices-2060169-7-interdiff.txt588 bytes

Ok once again with a test

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Needs work 
+++ b/past.test
@@ -241,6 +241,15 @@ class PastTest extends DrupalWebTestCase {
+    $this->drupalGet('');

No need for a drupalGet() here.

When writing regression tests, include a test-only.patch that proves that the test fails against the current code base.

s_leu’s picture

s_leu commented
Status: Needs work » Needs review
StatusFileSize
new php_errors_notices-2060169-9-interdiff.txt362 bytes
new php_errors_notices-2060169-9.patch2.03 KB
new php_errors_notices-2060169-9-testonly.patch561 bytes
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Perfect, committed and pushed.

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

The errors are printed on the top of EVERY page on the site.