The interface ContainerDerivativeInterface is I understand intended to extend DerivativeInterface, rather than implementers using both interfaces.

Must admit it baffled me a while, why all implementation of ContainerDerivativeInterface implemented the methods from DerivativeInterface but it seemed to be replacing it rather then also implementing it or extending DerivativeBase.

So as it's in the same namespace just:


-interface ContainerDerivativeInterface {
+interface ContainerDerivativeInterface extends DerivativeInterface {

Will add patch too.

CommentFileSizeAuthor
#3 2059637-03-drupal_containerderivativeinterface.patch794 bytesekes
#1 2059637-01-drupal_containerderivativeinterface.patch623 bytesekes

Comments

ekes’s picture

ekes commented
StatusFileSize
new 2059637-01-drupal_containerderivativeinterface.patch623 bytes
damiankloip’s picture

damiankloip commented
Status: Active » Needs work

They are in different namespaces so you'll need to use Drupal\Component\Plugin\Derivative\DerivativeInterface; too. One is in Core and, the other in Component :)

ekes’s picture

ekes commented
Status: Needs work » Needs review
StatusFileSize
new 2059637-03-drupal_containerderivativeinterface.patch794 bytes

Ops. Completely misread that.

damiankloip’s picture

damiankloip commented
Status: Needs review » Reviewed & tested by the community

Looks good, and should come back green

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 7a83e59 and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.