Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
views.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
7 Aug 2013 at 13:28 UTC
Updated:
29 Jul 2014 at 22:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
damiankloip commentedSo we could do this?
Comment #3
dawehnerThis was actually a helpful comment.
Mh another helpful one which got dropped.
Let's use \Drupal\views\ReusltRow[] instead.
I a follow up we could provide that code on the constructor for the ResultRow object.
Comment #4
damiankloip commentedThanks for the review.
I have added those comments back in, it does make sense to keep those. Also, I think we might as well move that logic to the ResultRow constructor now, as the code change is not much different because we can remove it from the CounterTest.
Comment #5
dawehnerThanks for doing that changes!
Comment #6
alexpottCommitted fd76691 and pushed to 8.x. Thanks!