#2032341: Remove 'image' and 'link' plugins from bundled CKEditor build was tackled as part of #2036253: Update CKEditor library to 4.2. I forgot to do one tiny part of it. This patch removes the last remnant.

CommentFileSizeAuthor
#5 cke_image_link_remnant-2057981-5.patch2.45 KBwim leers
#2 cke_image_link_remnant-2057981-2.patch2.52 KBwim leers
#2 interdiff.txt1.47 KBwim leers
cke_image_link_remnant.patch1.01 KBwim leers

Comments

Status: Needs review » Needs work
Issue tags: +sprint, +Spark, +CKEditor in core

The last submitted patch, cke_image_link_remnant.patch, failed testing.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt1.47 KB
new cke_image_link_remnant-2057981-2.patch2.52 KB

Forgot to update the tests. This is green.

nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Needs review » Reviewed & tested by the community
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Needs work

Yay, less code! :P

Unfortunately, no longer applies. :(

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new cke_image_link_remnant-2057981-5.patch2.45 KB

Straight reroll.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x while it's hot. ;) Thanks!

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue tags: -sprint

.

Automatically closed -- issue fixed for 2 weeks with no activity.