Both #2056415: Remove Unused local variable $function from /core/update.php and #2056417: Remove Unused local variable $person_uri from /core/modules/rdf/lib/Drupal/rdf/Tests/UserAttributesTest.php introduced incorrect file permissions. I've developed a git pre-commit hook to get so I don't do this anymore. Attached for others to this issue.

CommentFileSizeAuthor
#4 2057445.file-perms.4.patch614 bytesalexpott
#3 2057445.file-perms.3.patch351 bytesalexpott
#1 2057445.file-perms.1.patch248 bytesalexpott
pre-commit.txt686 bytesalexpott

Comments

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review
StatusFileSize
new 2057445.file-perms.1.patch248 bytes

Patch attached

ParisLiakos’s picture

ParisLiakos commented

we could include fix for #2039091: drupal_bootstrap docs are missing phases here as well

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
StatusFileSize
new 2057445.file-perms.3.patch351 bytes

Certainly!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
StatusFileSize
new 2057445.file-perms.4.patch614 bytes

Well let's clean up the one remaining!!!

$ find ./core/ -type f -not -perm 0644
./core//assets/vendor/jquery.ui/themes/base/images/ui-bg_flat_0_aaaaaa_40x100.png
./core//assets/vendor/jquery.ui/themes/base/images/ui-bg_glass_55_fbf9ee_1x400.png
./core//assets/vendor/jquery.ui/themes/base/images/ui-bg_glass_65_ffffff_1x400.png
./core//assets/vendor/jquery.ui/themes/base/images/ui-bg_glass_75_dadada_1x400.png
./core//assets/vendor/jquery.ui/themes/base/images/ui-bg_glass_75_e6e6e6_1x400.png
./core//assets/vendor/jquery.ui/themes/base/images/ui-bg_highlight-soft_75_cccccc_1x100.png
./core//assets/vendor/jquery.ui/themes/base/images/ui-icons_222222_256x240.png
./core//assets/vendor/jquery.ui/themes/base/images/ui-icons_2e83ff_256x240.png
./core//assets/vendor/jquery.ui/themes/base/images/ui-icons_454545_256x240.png
./core//assets/vendor/jquery.ui/themes/base/images/ui-icons_888888_256x240.png
./core//assets/vendor/jquery.ui/themes/base/images/ui-icons_cd0a0a_256x240.png
./core//modules/aggregator/tests/modules/aggregator_test_views/test_views/views.view.test_aggregator_items.yml
./core//scripts/drupal.sh
./core//scripts/password-hash.sh
./core//scripts/run-tests.sh
./core//scripts/update-countries.sh
./core//vendor/phpunit/phpunit/build/assertions.php
./core//vendor/phpunit/phpunit/composer/bin/phpunit
./core//vendor/phpunit/phpunit/phpunit.php
./core//vendor/symfony/http-kernel/Symfony/Component/HttpKernel/Tests/Config/FileLocatorTest.php

Ignore /vendor and /scripts we have ./core//modules/aggregator/tests/modules/aggregator_test_views/test_views/views.view.test_aggregator_items.yml

ParisLiakos’s picture

ParisLiakos commented
Status: Needs review » Reviewed & tested by the community

awesomeness. thanks

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Wow. Sorry about that.

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.