If the initial history and the final cron run happen in the same second during LocaleUpdateCronTest then the test will fail. We need to use sleep to ensure that time has passed. This can happen on testbot 1258 cause it is super fast.

CommentFileSizeAuthor
#2 2057247.locale-quick-test.2.patch806 bytesalexpott
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented

For example https://qa.drupal.org/pifr/test/589868

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Active » Needs review
FileSize
2057247.locale-quick-test.2.patch806 bytes

Here's a patch

olli’s picture

olli CreditAttribution: olli commented
Issue tags: +Random test failure

I saw this here https://qa.drupal.org/pifr/test/589768 with testbot 1718.

Tagging.

chx’s picture

chx CreditAttribution: chx commented
Status: Needs review » Reviewed & tested by the community

Sad thing to sleep in tests but I see no better idea.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Slower test suite == sad panda. :( Nevertheless, nice catch.

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.