Routes with optional placeholders can fatal when placed in a menu

can we use null instead of - in the yaml?

+++ b/core/includes/menu.incundefined
@@ -2803,11 +2803,11 @@ function menu_router_build($save = FALSE) {
-  return preg_replace('/{' . DRUPAL_PHP_FUNCTION_PATTERN . '}/', '%', $path);

+++ b/core/modules/system/tests/modules/menu_test/menu_test.moduleundefined
@@ -438,6 +438,11 @@ function menu_test_menu() {
+    'type' => MENU_LOCAL_TASK,

Isn't it a bit safer, especially in the future, to just rely on 'type' => MENU_NORMAL_ITEM?

According to http://yaml.org/type/null.html there is support for both '~', 'null', etc. Currently all of the conversions went with ~ but I do actually prefer 'null', so you don't have to guess what "~" could mean.

The getPatternOutline() is the perfect method, as it gets the stripped path, see

    $stripped_path = static::getPathWithoutDefaults($route);
    $pattern_outline = static::getPatternOutline($stripped_path);

okay, let's go with it.

@alexpott and I both also prefer the explicit NULL to the ~, and NULL is what we use elsewhere in core. ("Elsewhere" being Views UI.)

Oh, re:

According to http://yaml.org/type/null.html there is support for both '~', 'null', etc. Currently all of the conversions went with ~ but I do actually prefer 'null', so you don't have to guess what "~" could mean.

grep -r ": ~" * | grep "\.routing\.yml" | grep -v "vendor"

returns no results. So unless these conversions are still being worked on?

Sorry, I meant to set this back to NR.

Why NR? This is literally the least important part of the patch. It's YAML, they're equivalent, done.

Because @alexpott asked me to make the change, and I wanted to let @dawehner give feedback on it because of #3 and #8, and I don't RTBC my own changes to functional code or tests.

Edit: Aren't you supposed to have no laptop?

@xjm - the YAML spec says "null" not "NULL"?

@xjm - the YAML spec says "null" not "NULL"?

I just read it and it specifies any of the following:

 ~ # (canonical)
|null|Null|NULL # (English)
| # (Empty)

http://yaml.org/type/null.html

Since NULL is consistent with our coding standards elsewhere, and since we also use TRUE and FALSE in yaml, I went with NULL.

Committed 4e0d7b5 and pushed to 8.x. Thanks!