Part of meta-issue #2002650: [meta, no patch] improve maintainability by removing unused local variables

File /core/modules/field/lib/Drupal/field/Tests/FieldImportCreateTest.php

Line 58: Unused local variable $instance_2a
Line 60: Unused local variable $instance_2b

CommentFileSizeAuthor
#1 2056761-instance-2a-field-import-create-test.patch986 bytesjan.stoeckler

Comments

jan.stoeckler’s picture

jan.stoeckler
he/his
Primary language German
commented
Status: Active » Needs review
StatusFileSize
new 2056761-instance-2a-field-import-create-test.patch986 bytes

From what I can tell, the variables $instance_id_2a and $instance_id_2b are no longer of use after applying this patch.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Status: Needs review » Reviewed & tested by the community

Well they are in fact still used, so this patch does not introduce any new unused local variables.

The only usage is e.g.

    $this->assertFalse(entity_load('field_instance', $instance_id_2a));

It should probably removed entirely, but that would take someone digging in the commit history what the purpose of this used to be, if anything. So let's do that in a separate issue.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 353dcd9 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.