Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Part of meta-issue #2002650: [meta, no patch] improve maintainability by removing unused local variables
File /core/modules/field/lib/Drupal/field/Tests/FieldImportCreateTest.php
Line 58: Unused local variable $instance_2a
Line 60: Unused local variable $instance_2b
Comment | File | Size | Author |
---|---|---|---|
#1 | 2056761-instance-2a-field-import-create-test.patch | 986 bytes | jan.stoeckler |
Comments
Comment #1
jan.stoecklerFrom what I can tell, the variables $instance_id_2a and $instance_id_2b are no longer of use after applying this patch.
Comment #2
tstoecklerWell they are in fact still used, so this patch does not introduce any new unused local variables.
The only usage is e.g.
It should probably removed entirely, but that would take someone digging in the commit history what the purpose of this used to be, if anything. So let's do that in a separate issue.
Comment #3
alexpottCommitted 353dcd9 and pushed to 8.x. Thanks!