Illegal string offset test exceptions in PHP 5.4 in drupal_add_library()

This is green.

As often with this, this could actually indicate a real and weird bug with this shorthand version. Because what happens is basically this:

$string = 'Hello there';
$string['group'] = -100;
print $string;
-ello there

Not sure if there's a useful way to test this, though.

Well, we already have test coverage for that case, that's what's causing the exception in 5.4. The problem is that the bug shows in a weird way, not sure how to write a useful test for this:

What happens in 8.x is this output:

<script src="http://d8/core/assets/vendor/jquery/jquery.js?v=2.0"></script>
<script src="http://d8/core/assets/vendor/jquery.ui/external/jquery.cookie.js?v=1.10.2"></script>
<script src="http://d8/core/assets/vendor/jquery-form/jquery.form.js?v=3.27"></script>
<script src="http://d8/core/assets/vendor/farbtastic/farbtastic.js?v=1.2"></script>
<script src="http://d8/core/modules/system/tests/modules/common_test/js/shorthand.js?v=0.8.3.37"></script>
<script src="http://d8/-ore/modules/system/tests/modules/common_test/js/shorthand.js?0"></script>

And with the fix

<script src="http://d8/core/assets/vendor/jquery/jquery.js?v=2.0"></script>
<script src="http://d8/core/assets/vendor/jquery.ui/external/jquery.cookie.js?v=1.10.2"></script>
<script src="http://d8/core/assets/vendor/jquery-form/jquery.form.js?v=3.27"></script>
<script src="http://d8/core/assets/vendor/farbtastic/farbtastic.js?v=1.2"></script>
<script src="http://d8/core/modules/system/tests/modules/common_test/js/shorthand.js?0"></script>

So in 8.x, we have two entries. One that is correct, including the correct version and a broken one with the -.

Looking into this, I noticed that the shorthand => array() conversion already happens in drupal_get_library(), but it doesnt' remove the old entry. And my change actually broke the correct version handling there. So removed that and added an unset() in drupal_get_library().

The assert once test addition is kinda weird, but this combined should fail both with my previous patch and HEAD.

webchick++

+++ b/core/includes/common.incundefined
@@ -2761,6 +2761,17 @@ function drupal_add_library($module, $name, $every_page = NULL) {
           if ($type == 'js' && !isset($options['group'])) {

Ah, the reason the first test doesn't fail on 5.3 is this.

This is already converted to !isset($options[0]) and $options is a string, so it is set and never goes into the if.

Crazy stuff.