Part of meta-issue #2002650: [meta, no patch] improve maintainability by removing unused local variables

File /core/modules/rdf/lib/Drupal/rdf/Tests/UserAttributesTest.php

Line 57: Unused local variable $person_uri

CommentFileSizeAuthor
#2 2056417_unuse_variables-1.patch695 bytesMarcus Maihoff

Comments

Marcus Maihoff’s picture

Marcus Maihoff commented
Assigned: Unassigned » Marcus Maihoff
Issue tags: +Drupal-Camping 2013
Marcus Maihoff’s picture

Marcus Maihoff commented
Status: Active » Needs review
StatusFileSize
new 2056417_unuse_variables-1.patch695 bytes
tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Status: Needs review » Reviewed & tested by the community

Looks great @Marcus Maihoff! Thanks for the patch and welcome to the core team. :-)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed bb654e1 and pushed to 8.x. Thanks!

ParisLiakos’s picture

ParisLiakos commented
Status: Fixed » Needs work 
diff --git a/core/modules/rdf/lib/Drupal/rdf/Tests/UserAttributesTest.php b/core/modules/rdf/lib/Drupal/rdf/Tests/UserAttributesTest.php
old mode 100644
new mode 100755

this shouldnt happen:)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs work » Fixed

Handling this over in #2057445: Fix file wrong file perms introduced by 2056415 and 2056417

Automatically closed -- issue fixed for 2 weeks with no activity.