When the default setting for an argument is "Use empty text", any user who does not have administer nodes permission and loads the view without the argument will get an SQL error. This is because db_rewrite_sql() adds join and where clauses even to empty queries.

CommentFileSizeAuthor
#3 views.module-205390.patch598 bytesDarren Oh
#1 views.module-205390.patch590 bytesDarren Oh
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Darren Oh’s picture

Darren Oh
Primary language English
Location Lakeland, Florida
CreditAttribution: Darren Oh commented
Status: Active » Reviewed & tested by the community
FileSize
views.module-205390.patch590 bytes

The attached patch adds a test for empty queries.

digikami’s picture

digikami CreditAttribution: digikami commented 
-  $query = db_rewrite_sql($info['query'], 'node');
+  if (!empty($query)) {
+    $query = db_rewrite_sql($info['query'], 'node');
+  }

should probably be

-  $query = db_rewrite_sql($info['query'], 'node');
+  if (!empty($info['query'])) {
+    $query = db_rewrite_sql($info['query'], 'node');
+  }
Darren Oh’s picture

Darren Oh
Primary language English
Location Lakeland, Florida
CreditAttribution: Darren Oh commented
FileSize
views.module-205390.patch598 bytes

Good catch.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Priority: Normal » Critical

Bumping priority since there's a few duplicates around.

dropcube’s picture

dropcube CreditAttribution: dropcube commented

If a module that rewrites queries is installed and an empty query is generated by _views_get_query and error is caused due to db_rewrite_sql() generates an incorrect query.
The above patch fixes the issue.

suit4’s picture

suit4 CreditAttribution: suit4 commented

Patch views.module-205390.patch works for me, too.

bwong’s picture

bwong CreditAttribution: bwong commented

I found this the hard way, using the Trace module. This patch works for me.

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Status: Reviewed & tested by the community » Fixed

This was already fixed in #247420: SQL error when using empty text as argument default and #217015: Views module sends null query when building a block, and has been committed.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.