In Drupal 5, one could not de-select the forum node type form the forum vocabulary:
http://api.drupal.org/api/function/forum_form_alter/5

In Drupal 6, it can be deselcted - is this intended?

There is also a bug in forum_form_alter - apparently the form array changed.

On admin/content/forum/settings there is a bug in the help text- the link is invalid.

Initial patch attached.

Comments

gábor hojtsy’s picture

- Keep the dash in the help text and use the dashed version on the variable array please.
- I am not sure that is is explicitly intentional that you can remove the forum node type from the forum vocabulary, but why not? :) Let's say you use the forum module to organize some other type of posts you built up with CCK. This sounds like a weird idea. I am just trying to make up use cases, playing the devils advocate.

gábor hojtsy’s picture

Status: Needs review » Needs work
keith.smith’s picture

Status: Needs work » Needs review
StatusFileSize
new2.11 KB

I rerolled pwolanin's patch to use the dashed version in the help text, rather than the underscore.

(please don't credit me on this commit -- I just rerolled it because I was probably the one that caused it. :) )

pwolanin’s picture

Title: forum type can be deselcted in forum vocab, and hook_help bug » no forum type required in forum vocab, and hook_help bug
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new2.04 KB

@Gabor - I think you're correct that it is intentional for D6 that the forum type can be removed.

so, attached patch just fixes the 2 trivial bugs.

pwolanin’s picture

Assigned: Unassigned » pwolanin
gábor hojtsy’s picture

Status: Reviewed & tested by the community » Fixed

Thanks, committed.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.