Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Updated: Comment #0
Problem/Motivation
In documenting the variables in these preprocess functions, views_preprocess_comment() refers to template_preprocess_views_view_row_comment() which doesn't exist, and views_preprocess_node() says that a variable is added in views_preprocess_node().
Proposed resolution
Correct these comments to indicate where the variables are added.
Remaining tasks
Patch needs review.
User interface changes
n/a
API changes
n/a
Related Issues
This issue spawned from #1751194: Introduce hook_theme_suggestions[_HOOK]() and hook_theme_suggestions[_HOOK]_alter().
Comment | File | Size | Author |
---|---|---|---|
#3 | 2050883-3.patch | 1.37 KB | star-szr |
#3 | interdiff.txt | 819 bytes | star-szr |
#1 | 2050883-1.patch | 1.37 KB | star-szr |
Comments
Comment #1
star-szrComment #2
tstoecklerThe indentation in the second hunk looks off.
Comment #3
star-szrD'oh :) thanks @tstoeckler!
Comment #4
jhodgdonWhitespace looks better now. :)
If someone could review for accuracy?
Comment #5
dawehner+1 from my perspective.
Comment #6
jhodgdonThanks! I'll get this committed shortly.
Comment #7
jhodgdonThanks again! Committed to 8.x.