Updated: Comment #0

Problem/Motivation

In documenting the variables in these preprocess functions, views_preprocess_comment() refers to template_preprocess_views_view_row_comment() which doesn't exist, and views_preprocess_node() says that a variable is added in views_preprocess_node().

Proposed resolution

Correct these comments to indicate where the variables are added.

Remaining tasks

Patch needs review.

User interface changes

n/a

API changes

n/a

This issue spawned from #1751194: Introduce hook_theme_suggestions[_HOOK]() and hook_theme_suggestions[_HOOK]_alter().

CommentFileSizeAuthor
#3 2050883-3.patch1.37 KBstar-szr
#3 interdiff.txt819 bytesstar-szr
#1 2050883-1.patch1.37 KBstar-szr

Comments

star-szr’s picture

star-szr
he/him
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new 2050883-1.patch1.37 KB
tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Status: Needs review » Needs work

The indentation in the second hunk looks off.

star-szr’s picture

star-szr
he/him
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt819 bytes
new 2050883-3.patch1.37 KB

D'oh :) thanks @tstoeckler!

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

Whitespace looks better now. :)

If someone could review for accuracy?

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

+1 from my perspective.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

Thanks! I'll get this committed shortly.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Thanks again! Committed to 8.x.

Automatically closed -- issue fixed for 2 weeks with no activity.