Users 0 and 1 are created without a UUID

Will work on this on the weekend.

The problem was there is no data provided for UUID by the user.install.

Tested on local - works fine. Let's see what Test bot will say.

This should use the uuid service.

And it's quite crazy that this doesn't use the storage controller...

#2092603: Users 0 and 1 have no UUID was marked duplicate.
#2090541: Avoid storing numeric target_id's for default values in field instance CMI files is hitting this.

This should use the uuid service.

The uuid is not a service yet.

And it's quite crazy that this doesn't use the storage controller...

I agree, maybe some problems with order of bootstrapping in the installer or just some historical reasons.

It would be cool to have a test.

3: drupal8-users-0-and-1-are-created-without-a-uuid-2050843.patch queued for re-testing.

Per anavarre, this is apparently preventing POST requests in REST so seems at least major...

Well, posting as anon always: #2113681: Node author can't be set when posting via HAL

#2158581: uid 1 is created without uuid was marked as duplicate.

Attached patch should fix the bug. Still needs two test assertions somewhere. Ideally in an existing installer-specific test.

The UUID generator is a service now.

@Berdir You jumped me was just about to release a patch for this using the Drupal::Service method. Just a point you don't need the additional use Drupal\Component\Uuid\Uuid declaration at the top as you are using the Uuid through a Drupal Service not directly! Also it may be better to declare a $uuid = \Drupal::service('uuid'); variable at the top of the install hook and then just use $uuid->generate() instead of making 2 calls to the Drupal Service to get UUID when it is needed.

@luketarplin: Sorry :)

Yes, I based my patch on sun's and forgot the remove the use. Feel free to upload your patch :)

Removed the unecessary use.

Thanks!

You removed another unnecessary Field use statement there but not the Uuid use statement. However, in general, we should not care for such stuff right now. AFAIK, IDEs like phpStorm are able to perform such a clean-up automatically, across all files. Therefore, we should perform such a clean-up just simply once right before release, instead of holding up patches for it.

Re-uploading the identical patch sans the first hunk in user.install to avoid further delays → RTBC.

Works as expected now, thanks!

mysql> SELECT uid,uuid FROM users;
+-----+--------------------------------------+
| uid | uuid                                 |
+-----+--------------------------------------+
|   1 | 15999b22-8410-4c87-8f00-d32a1da2b892 |
|   0 | 6417b88a-8a12-4e90-8504-4b724c2a791d |
+-----+--------------------------------------+
2 rows in set (0.00 sec)

Hopefully this will unblock #1979260: Automatically populate the author default value with the current user and #2113681: Node author can't be set when posting via HAL

Great catch.

Committed and pushed to 8.x. Thanks!