Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
FieldInstanceFormBase is only extended by FieldInstanceEditForm, the two should be merged ?
Unneeded abstraction --.
Comment | File | Size | Author |
---|---|---|---|
#5 | 2050367-5.patch | 5.75 KB | amateescu |
#5 | interdiff.txt | 603 bytes | amateescu |
#2 | 2050367.patch | 5.73 KB | amateescu |
Comments
Comment #1
andypostMakes sense
Comment #2
amateescu CreditAttribution: amateescu commentedYep, it's totally useless. I was wondering the same thing recently while I was working on another issue, so I'm glad you opened this one.
Comment #3
yched CreditAttribution: yched commentedThanks !
RTBC if green.
Comment #5
amateescu CreditAttribution: amateescu commentedJust missing a 'use' statement.
Comment #6
alexpottCommitted 94cf43e and pushed to 8.x. Thanks!