As a extension of the issue https://drupal.org/node/2049465

When I does to any migrated style image manage page I got

Notice: Undefined index: id in Drupal\image\ImageEffectBag->initializePlugin() (line 58 of core/modules/image/lib/Drupal/image/ImageEffectBag.php).
Drupal\Component\Plugin\Exception\PluginException: The plugin () did not specify an instance class. в функции Drupal\Component\Plugin\Factory\DefaultFactory::getPluginClass() (строка 62 в файле /home/dev/domains/d8.dev.bighameleon.com/core/lib/Drupal/Component/Plugin/Factory/DefaultFactory.php).

see attached screenshot

I try to create style image with same effects
and compare it config
hend made image style config

name: test
label: test
uuid: a9d83b8c-71e6-4508-9d00-c3e61aceeee4
status: '1'
langcode: ru
effects:
  52676e26-7d86-44d6-9b00-d3605b6f4388:
    uuid: 52676e26-7d86-44d6-9b00-d3605b6f4388
    id: image_scale
    weight: '1'
    data:
      width: '80'
      height: '80'
      upscale: '0'

migrated image style

name: 80x80
effects:
  835163a6-7726-4841-b304-048bb1f43d29:
    ieid: 835163a6-7726-4841-b304-048bb1f43d29
    weight: '1'
    name: image_scale
    data:
      width: '80'
      height: '80'
      upscale: '0'
label: 80x80

label key was added with image_update_8003 form patch https://drupal.org/node/2049465#comment-7681071

more complex checks shows me that this bug looks like

function _image_update_get_style_with_effects(array $style)

from image.install not work properly

Comments

tim.plunkett’s picture

_image_update_get_style_with_effects() does

$effect['id'] = $effect['name'];

That is a relatively recent change.
When did you attempt to do the update?

niko-’s picture

This update must be run when site migrating.
But I not sure if it relly run.

niko-’s picture

oh sorry site migrated 20.07

tstoeckler’s picture

Priority: Normal » Critical
Issue tags: +Needs upgrade path tests

upgrade path -> critical

niko-’s picture

some additional info about this issue

I rechecked it on recent d8 from git (this morning git clone) effects are shows in admin, but styles configuration are incorrect
updated style config looks like

name: 80x80
effects:
  bf939d9c-baa0-4b45-a900-0a843eaf0cc6:
    weight: '1'
    data:
      width: '80'
      height: '80'
      upscale: '0'
    uuid: bf939d9c-baa0-4b45-a900-0a843eaf0cc6
    id: image_scale
label: 80x80

we have no next keys in style configs

uuid: a9d83b8c-71e6-4508-9d00-c3e61aceeee4
status: '1'
langcode: ru

So one more patch needed

niko-’s picture

StatusFileSize
new1.42 KB

patch attached (including https://drupal.org/node/2049465 )

andypost’s picture

...and again - image styles now have labels in D7 #606598: Human readable image-style names
so after next D7 point release will have this hook_update_n() to add labels

But once we have 2 kinds of d7 releases (security and featured) D8 should check that field in table

andypost’s picture

Status: Active » Closed (duplicate)

This is a upgrade path bug so marked as duplicate #2049465: Upgrade of image styles and effects broken