TranslationManager::translate() should be on an interface

Hello,

I glimpsed this issue and found that TranslatorInterface is implemented by 3 classes:

• Drupal\Core\StringTranslation\TranslationManager
• Drupal\Core\StringTranslation\Translator\StaticTranslation
• Drupal\locale\LocaleTranslation

But only Drupal\Core\StringTranslation\TranslationManager class provides translate method. Then, I don't know exactly how should we face with this issue, because if this method is added to the interface, all these classes should implement this method.

Maybe we could extend TranslatorInterface and implement this new interface only in TranslationManager class.

What do you think?

Regards

Including patch based on #2049709-8: TranslationManager::translate() should be on an interface, just removing the __invoke() call, which I think is not covered in this issue.

However, this patch does not address the issue title given that this method is not included in TranslatorInterface.
What do you think?

Regards.

I try to figure out why we both need Translator and TranslationInterface. Is it really impossible to combine this two methods into one?

well TranslationManager is actually a translator manager class that "holds" many translators and it can act as a translator by having its own getStringTranslation method, in where it loops through its translators till it retrieves a translation.
Almost same pattern with PathProcessorManager.
(Maybe the naming is wrong all along and should be named TranslatorManager?)

We could add this method to TranslatorInterface, but then we would need a base/abastract class to hold the logic instead of it being only in the manager class.
BUT I think having a TranslationInterface is better, since it allows a totally different translation system (with or without translators). You can think of Translators being an implementation detail of core's string translation. A string translation itself only needs to have the translate method.

If the fact that TranslationManager implementing the TranslatorInterface is confusing, we can remove it and just make it implement TranslationInterface, not both, but we should keep translate() method out of translators

If the fact that TranslationManager implementing the TranslatorInterface is confusing, we can remove it and just make it implement TranslationInterface, not both

this can be addressed in seperate issue so imo is rtbc. Tagging though for more opinions

well, the sooner we get this in, the better

Committed 3e83934 and pushed to 8.x. Thanks!