File usage views should be combined [#2049479]

#2005166: Create simple file listing under admin/content/file added two views:
admin/content/files for an overview
admin/content/files/usage/% for a single file's usage info

These were added as two separate views, but they should have been a single view with two displays.

While rebuilding this, I noticed the breadcrumbs were broken for the file usage view.
I found that fix, which can be split out if needed.

Comment	File	Size	Author
#6	file-2049479-6.patch	22.48 KB	tim.plunkett
#6	interdiff.txt	1.83 KB	tim.plunkett
#3	interdiff.txt	423 bytes	tim.plunkett
#3	file-2049479-3.patch	22.55 KB	tim.plunkett
#1	file-2049479-1.patch	23.14 KB	tim.plunkett
#1	before.png	15.9 KB	tim.plunkett
#1	after.png	19.92 KB	tim.plunkett

Comments

Comment #1

tim.plunkett

he/him

English

Philadelphia

commented 24 July 2013 at 16:29

Status:

Active

» Needs review

Status	File	Size
new	after.png	19.92 KB
new	before.png	15.9 KB
new	file-2049479-1.patch	23.14 KB

Before:

After:

Comment #2

dawehner

German

commented 24 July 2013 at 17:51

+++ b/core/modules/file/config/views.view.files.ymlundefined
@@ -571,6 +598,360 @@ display:
+        type: full

Let's use the minipager.

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/display/PathPluginBase.phpundefined
@@ -178,10 +178,6 @@ public function executeHookMenu($callbacks) {
       switch ($menu['type']) {
-        case 'none':
-        default:
-          $items[$path]['type'] = MENU_CALLBACK;
-          break;

Isn't that really out of scope?