Part of #2046981: [META] Inject dependencies into plugin derivative classes

CommentFileSizeAuthor
#6 2049079-6.patch4.53 KBdamiankloip
#6 interdiff-2049079-6.txt760 bytesdamiankloip
#3 2049079-3.patch4.41 KBdamiankloip
#3 interdiff-2049079-3.txt3.28 KBdamiankloip
#1 2049079-1.patch3.38 KBdamiankloip
#1 interdiff-2049079-1.txt1.03 KBdamiankloip
AggregatorCategoryBlock-injection.patch2.99 KBdamiankloip

Comments

damiankloip’s picture

damiankloip commented
StatusFileSize
new interdiff-2049079-1.txt1.03 KB
new 2049079-1.patch3.38 KB

Meh

dawehner’s picture

dawehner
Primary language German
commented 
+++ b/core/modules/aggregator/lib/Drupal/aggregator/Plugin/Derivative/AggregatorCategoryBlock.phpundefined
@@ -24,13 +26,43 @@ class AggregatorCategoryBlock implements DerivativeInterface {
     $this->derivatives[$derivative_id]['admin_label'] = t('@title category latest items', array('@title' => $result->title));

yeah another one.

damiankloip’s picture

damiankloip commented
StatusFileSize
new interdiff-2049079-3.txt3.28 KB
new 2049079-3.patch4.41 KB

Yep!

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Thank you!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work 
+++ b/core/modules/aggregator/lib/Drupal/aggregator/Plugin/Derivative/AggregatorCategoryBlock.phpundefined
@@ -24,16 +27,57 @@ class AggregatorCategoryBlock implements DerivativeInterface {
+    $this->basePluginId = $base_plugin_id;

Missing @var and protected for $this->basePluginId

damiankloip’s picture

damiankloip commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-2049079-6.txt760 bytes
new 2049079-6.patch4.53 KB
dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Finally

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 6513936 and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.