Views Grid style: tokens not replaced in custom row/column classes

Hmm, indeed. That's unfortunate. Sigh... ok we'll probably need to implement something like: StylePluginBase::getRowClass

We need to extend the grid test to include this so we don't miss this again.

This is an AMAZING "stab"!! Great patch! Test only patch fails like it should, complete passes!

@Les Lim++

One tiny code standards nitpick:

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/style/Grid.php
@@ -104,4 +104,22 @@ public function buildOptionsForm(&$form, &$form_state) {
+  /**
+   * Return the token-replaced row or column classes for the specified
+   * result item.
+   */

This should be a single summary line. @see: https://drupal.org/node/1354#drupal

No need to upload a new "test" only patch. Just the revised complete patch will do. After that new patch turns green, this is RTBC!

Also, afterthought:

+++ b/core/modules/views/lib/Drupal/views/Tests/Plugin/StyleGridTest.php
@@ -102,6 +102,11 @@ protected function assertGrid(ViewExecutable $view, $alignment, $columns) {
+    // Ensure tokens are being replaced in custom row/column classes.
+    $result = $this->xpath('//div[contains(@class, "views-col") and contains(@class, "name-John")]');
+    $this->assertTrue(count($result), 'Token replacement verified in custom column classes.');
+    $result = $this->xpath('//div[contains(@class, "views-row") and contains(@class, "age-25")]');
+    $this->assertTrue(count($result), 'Token replacement verified in custom row classes.');

I would keep the same assertion label prefix so it's easier to read in the tests if they fail (ie: look at the test only results).

I would do something like:
ucfirst($alignment) . " $columns column grid: Custom column class token replaced."
and
ucfirst($alignment) . " $columns column grid: Custom row class token replaced."

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/style/Grid.php
@@ -104,4 +104,20 @@ public function buildOptionsForm(&$form, &$form_state) {
+  /**
+   * Return the token-replaced row or column classes for the specified result.
+   */

The summary line still needs to be less than 80 characters long.

  /**
   * Returns token-replaced custom row or column classes.
   */

It is great that this also extends the test coverage of checking for the col and row classes. Here is some additional nickpicking.

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/style/Grid.phpundefined
@@ -104,4 +104,20 @@ public function buildOptionsForm(&$form, &$form_state) {
+  /**
+   * Return the token-replaced row or column classes for the specified result.
+   */
+  public function getCustomClass($result_index, $type) {

The parameters and the return value should be documented.

This summary line is already under 80 characters (78), including indentation.

My bad, guess my Dreditor styling is off.

Changes look good, will RTBC once patch comes back green.

#12: core-2048897-12-complete.patch queued for re-testing.

Nice work guys.

• Fixes regression
• Has new test coverage to prevent future regression.

Committed 0932270 and pushed to 8.x. Thanks!