Part of #2046981: [META] Inject dependencies into plugin derivative classes

CommentFileSizeAuthor
#9 2047533-9.patch2.6 KBdamiankloip
#9 interdiff-2047533-9.txt832 bytesdamiankloip
#7 2047533-7.patch2.6 KBdamiankloip
#7 interdiff-2047533-7.txt1.48 KBdamiankloip
#3 2047533-3.patch2.33 KBdamiankloip
#3 interdiff-2047533-3.txt917 bytesdamiankloip
FieldItemDeriver-injection.patch2.09 KBdamiankloip

Comments

damiankloip’s picture

damiankloip commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, FieldItemDeriver-injection.patch, failed testing.

damiankloip’s picture

damiankloip commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-2047533-3.txt917 bytes
new 2047533-3.patch2.33 KB

Whoops, needs to implement the new interface.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

This looks great!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work 
+++ b/core/lib/Drupal/Core/Entity/Plugin/DataType/Deriver/FieldItemDeriver.phpundefined
@@ -22,6 +24,29 @@ class FieldItemDeriver implements DerivativeInterface {
+    $this->basePluginId = $base_plugin_id;
+    $this->fieldItemPluginManager = $field_item_plugin_manager;

Missing @var doc blocks and protected properties for $this->basePluginId and $this->fieldItemPluginManager

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

It should be field *type* plugin manager, no?

damiankloip’s picture

damiankloip commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-2047533-7.txt1.48 KB
new 2047533-7.patch2.6 KB

Yep, it should be fieldTypePluginManager for sure.

Status: Needs review » Needs work

The last submitted patch, 2047533-7.patch, failed testing.

damiankloip’s picture

damiankloip commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-2047533-9.txt832 bytes
new 2047533-9.patch2.6 KB

Sorry, didn't change the actual usage of it.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Okay great, let's store the value for consistency.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed d238a40 and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.