Comments

damiankloip’s picture

Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, FieldItemDeriver-injection.patch, failed testing.

damiankloip’s picture

Status: Needs work » Needs review
StatusFileSize
new917 bytes
new2.33 KB

Whoops, needs to implement the new interface.

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

This looks great!

alexpott’s picture

Status: Reviewed & tested by the community » Needs work
+++ b/core/lib/Drupal/Core/Entity/Plugin/DataType/Deriver/FieldItemDeriver.phpundefined
@@ -22,6 +24,29 @@ class FieldItemDeriver implements DerivativeInterface {
+    $this->basePluginId = $base_plugin_id;
+    $this->fieldItemPluginManager = $field_item_plugin_manager;

Missing @var doc blocks and protected properties for $this->basePluginId and $this->fieldItemPluginManager

berdir’s picture

It should be field *type* plugin manager, no?

damiankloip’s picture

Status: Needs work » Needs review
StatusFileSize
new1.48 KB
new2.6 KB

Yep, it should be fieldTypePluginManager for sure.

Status: Needs review » Needs work

The last submitted patch, 2047533-7.patch, failed testing.

damiankloip’s picture

Status: Needs work » Needs review
StatusFileSize
new832 bytes
new2.6 KB

Sorry, didn't change the actual usage of it.

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

Okay great, let's store the value for consistency.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed d238a40 and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.