Part of #2046981: [META] Inject dependencies into plugin derivative classes

CommentFileSizeAuthor
#9 2046993-9.patch2.8 KBdamiankloip
#9 interdiff-2046993-9.txt736 bytesdamiankloip
#4 2046993-4.patch2.68 KBdamiankloip
#4 interdiff-2046993-4.txt1.41 KBdamiankloip
#1 2046993.patch2.68 KBdamiankloip

Comments

damiankloip’s picture

damiankloip commented
Status: Active » Needs review
StatusFileSize
new 2046993.patch2.68 KB
dawehner’s picture

dawehner
Primary language German
commented

Nice!

+++ b/core/modules/views/lib/Drupal/views/Plugin/Derivative/ViewsExposedFilterBlock.phpundefined
@@ -24,6 +26,36 @@ class ViewsExposedFilterBlock implements DerivativeInterface {
+  public function __construct($base_plugin_id, EntityStorageControllerInterface $view_storage_controller) {

Lets move the __construct method to the top, as it is more important that create.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Needs work
damiankloip’s picture

damiankloip commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-2046993-4.txt1.41 KB
new 2046993-4.patch2.68 KB

Same again.. PHPStorm++

Status: Needs review » Needs work
Issue tags: -VDC

The last submitted patch, 2046993-4.patch, failed testing.

damiankloip’s picture

damiankloip commented
Status: Needs work » Needs review
Issue tags: +VDC

#4: 2046993-4.patch queued for re-testing.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Thank you very much!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work 
+++ b/core/modules/views/lib/Drupal/views/Plugin/Derivative/ViewsExposedFilterBlock.phpundefined
@@ -24,6 +26,36 @@ class ViewsExposedFilterBlock implements DerivativeInterface {
+    $this->basePluginId = $base_plugin_id;

Missing @var documentation and protected scope.

damiankloip’s picture

damiankloip commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-2046993-9.txt736 bytes
new 2046993-9.patch2.8 KB

Totally right. Here we go.

dawehner’s picture

dawehner
Primary language German
commented

I guess we need #2046983: Inject dependencies into ViewsEntityRow derivative class in first?

damiankloip’s picture

damiankloip commented

#9: 2046993-9.patch queued for re-testing.

Tis in.

damiankloip’s picture

damiankloip commented
Issue tags: +Needs tests

I will add a couple of tests here to EXposedFormTest - We need to test that exposed forms that have the exposed_block options do a. not show up as regular exposed and b. creates a block.

damiankloip’s picture

damiankloip commented
Issue tags: -Needs tests

I take it back, see #2057831: Exposed filter blocks do not work anymore - we should fix the other stuff over there.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented

#9: 2046993-9.patch queued for re-testing.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Perfect!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed cb5397f and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.