Support from Acquia helps fund testing for Drupal Acquia logo

Comments

damiankloip’s picture

Status: Active » Needs review
FileSize
2.34 KB
dawehner’s picture

+++ b/core/lib/Drupal/Core/Entity/Plugin/DataType/Deriver/EntityDeriver.phpundefined
@@ -22,6 +24,36 @@ class EntityDeriver implements DerivativeInterface {
+   * The plugin entity manager.

Oh another variant.

damiankloip’s picture

FileSize
999 bytes
2.32 KB

heh, yeah.

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

Thank you

alexpott’s picture

Status: Reviewed & tested by the community » Needs work
+++ b/core/lib/Drupal/Core/Entity/Plugin/DataType/Deriver/EntityDeriver.phpundefined
@@ -22,6 +24,36 @@ class EntityDeriver implements DerivativeInterface {
+    $this->basePluginId = $base_plugin_id;

Missing @var documentation and protected scope.

damiankloip’s picture

Status: Needs work » Needs review
FileSize
658 bytes
2.44 KB
dawehner’s picture

Status: Needs review » Reviewed & tested by the community

Finally.

alexpott’s picture

Status: Reviewed & tested by the community » Needs work
+++ b/core/lib/Drupal/Core/Entity/Plugin/DataType/Deriver/EntityDeriver.phpundefined
@@ -22,6 +24,43 @@ class EntityDeriver implements DerivativeInterface {
+   * Constructs a ViewsBlock object.

Damn... sorry but I don't think we constructing a ViewsBlock object here...

damiankloip’s picture

Status: Needs work » Needs review
FileSize
599 bytes
2.44 KB

It's true what they say... you really do have an eagle eye that legends are made of :)

dawehner’s picture

Damian: I am sorry.

+++ b/core/lib/Drupal/Core/Entity/Plugin/DataType/Deriver/EntityDeriver.phpundefined
@@ -22,6 +24,43 @@ class EntityDeriver implements DerivativeInterface {
+
+  /**
+   * Constructs an EntityDeriver object.
+   *
+   * @param string $base_plugin_id
+   *   The base plugin ID.
+   * @param \Drupal\Core\Entity\EntityManager $entity_manager
+   *   The entity manager.
+   */
+  public function __construct($base_plugin_id, EntityManager $entity_manager) {
+    $this->basePluginId = $base_plugin_id;
+    $this->entityManager = $entity_manager;
+  }

I kind of prefer to have the constructor first

damiankloip’s picture

%$^#%!! ;)

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

There we go.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed c7a9553 and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.