A part of #2046981: [META] Inject dependencies into plugin derivative classes.

CommentFileSizeAuthor
#10 2046983-10.patch4.76 KBdamiankloip
#10 interdiff-2046983-10.txt2.08 KBdamiankloip
#7 2046983-7.patch4.63 KBdamiankloip
#7 interdiff-2046983-7.txt952 bytesdamiankloip
#4 2046983-4.patch4.65 KBdamiankloip
#4 interdiff-2046983-4.txt1.42 KBdamiankloip
#1 2046983.patch4.65 KBdamiankloip

Comments

damiankloip’s picture

damiankloip commented
Status: Active » Needs review
StatusFileSize
new 2046983.patch4.65 KB
dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community 
+++ b/core/modules/views/lib/Drupal/views/Plugin/Derivative/ViewsEntityRow.phpundefined
@@ -27,6 +29,47 @@ class ViewsEntityRow implements DerivativeInterface {
+  public function __construct($base_plugin_id, EntityManager $entity_manager, ViewsData $views_data) {

Lets move the __construct method to the top, as it is more important that create.

dawehner’s picture

dawehner
Primary language German
commented
Status: Reviewed & tested by the community » Needs work 
+++ b/core/modules/views/lib/Drupal/views/Plugin/Derivative/ViewsEntityRow.phpundefined
@@ -27,6 +29,47 @@ class ViewsEntityRow implements DerivativeInterface {
+  public function __construct($base_plugin_id, EntityManager $entity_manager, ViewsData $views_data) {

Lets move the __construct method to the top, as it is more important that create.

damiankloip’s picture

damiankloip commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-2046983-4.txt1.42 KB
new 2046983-4.patch4.65 KB

Sure, phpstorm makes that take about...0.5 seconds :)

dawehner’s picture

dawehner
Primary language German
commented 
+++ b/core/modules/views/lib/Drupal/views/Plugin/Derivative/ViewsEntityRow.phpundefined
@@ -27,6 +29,47 @@ class ViewsEntityRow implements DerivativeInterface {
+   * The entity plugin manager.
...
+   *   The entity plugin manager.

Lets call it entity manager

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Needs work
damiankloip’s picture

damiankloip commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-2046983-7.txt952 bytes
new 2046983-7.patch4.63 KB

consistency is king.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Thank you!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work 
+++ b/core/modules/views/lib/Drupal/views/Plugin/Derivative/ViewsEntityRow.phpundefined
@@ -27,6 +29,47 @@ class ViewsEntityRow implements DerivativeInterface {
+    $this->basePluginId = $base_plugin_id;

Missing @var documentation and protected scope

damiankloip’s picture

damiankloip commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-2046983-10.txt2.08 KB
new 2046983-10.patch4.76 KB
dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Another one.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 2e29f25 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.