Follow up for #2042143: [META] Fix unsafe core translatable strings

Problem/Motivation

As said in the follow up issue, some strings cannot be translated due to the locale_string_is_safe function. It is the case for the <Any> string which can be chosen in the settings as a default value for exposed filters. Also, as discussed in #1317884: Remove all instances of <none>, <Hidden> and <br/> from translatable strings because they lead to import errors, we should improve string consistency on this kind of strings.

Proposed resolution

Remove all <Any> and &lt;Any&gt; strings in favor of - Any - and also remove all stuff related by the choice of the label in views_ui.

Cross reference : #2046533: End with "any" label configuration to improve consistency and localization

Credit

This issue was covered during the first Drupal Sprint of Montpellier (France).

CommentFileSizeAuthor
#3 drupal-views-remove_any_label_choice-2046537-3.patch3.78 KBduaelfr
#1 drupal-views-remove_any_label_choice-2046537-1.patch3.78 KBduaelfr

Comments

duaelfr’s picture

duaelfr
he/him
Primary language French
Location Montpellier, France
commented
Assigned: duaelfr » Unassigned
Status: Active » Needs review
StatusFileSize
new drupal-views-remove_any_label_choice-2046537-1.patch3.78 KB

Here is the patch !

Take care of the cross reference with #2046533: End with "any" label configuration to improve consistency and localization which is complementary.

duaelfr’s picture

duaelfr
he/him
Primary language French
Location Montpellier, France
commented
Issue summary: View changes

fix html issues

duaelfr’s picture

duaelfr
he/him
Primary language French
Location Montpellier, France
commented
Status: Needs review » Closed (duplicate)

Merged with #2046533: End with "any" label configuration to improve consistency and localization

duaelfr’s picture

duaelfr
he/him
Primary language French
Location Montpellier, France
commented
Status: Closed (duplicate) » Needs review
StatusFileSize
new drupal-views-remove_any_label_choice-2046537-3.patch3.78 KB

Oops !
Here is the merged patch.

This is the reference to the initial discussion about this kind of issues : https://drupal.org/node/1317884#comment-6976466

duaelfr’s picture

duaelfr
he/him
Primary language French
Location Montpellier, France
commented
Issue tags: +VDC

Adding VDC tag

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Let's make it consistent with the rest of Drupal core. I had a search and there was no test for it.

dawehner’s picture

dawehner
Primary language German
commented
Issue summary: View changes

Added credit

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 88cbedb and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Put around to let it be unfiltered

hass’s picture

hass commented
Issue summary: View changes
Status: Closed (fixed) » Active

This issue or #2046533: End with "any" label configuration to improve consistency and localization seems not fixed at all.

Under admin/structure/views/settings the suxxx <Any> label is still in the select list and not only this - it is the default value.

duaelfr’s picture

duaelfr
he/him
Primary language French
Location Montpellier, France
commented
Status: Active » Closed (fixed)
Related issues: +#2644584: Remove legacy setting allowing to use <Any> as default select value in Views exposed filters

@hass It's a legacy setting. I agree we should remove it too. Let's do this in a follow-up issue: #2644584: Remove legacy setting allowing to use <Any> as default select value in Views exposed filters