Closed (duplicate)
Project:
Drupal core
Version:
8.0.x-dev
Component:
configuration entity system
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
17 Jul 2013 at 13:11 UTC
Updated:
30 Jan 2015 at 01:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
freblasty commentedPatch which uses
EntityInterface::id()instead of retrieving id as a public member.Comment #2
freblasty commentedComment #3
tim.plunkettI wouldn't really call this a bug... It's done in some EntityStorageControllerInterface::save() implementations by necessity, I'm guessing this was copy/pasted.
But the fix is correct and it still applies.
Comment #4
jibran1: drupal-config-storage-controller-use-entity-interface-2044005.patch queued for re-testing.
Comment #6
tim.plunkett1: drupal-config-storage-controller-use-entity-interface-2044005.patch queued for re-testing.
Comment #7
freblasty commented1: drupal-config-storage-controller-use-entity-interface-2044005.patch queued for re-testing.
Comment #8
berdirWondering if this should be closed as a duplicate of #597236: Add entity caching to core, which moves the 3 identical snippets in the different loadMultiple() implementations into a helper method and solves this as well.
Comment #10
freblasty commented@Berdir will this issue be marked as duplicate or should I fix the patch?
Comment #11
berdirThat issue got in a while ago, so closing this now, yes.