Slogan shown on installation pages

The styling for the installation screen is contained in the Seven theme. In my opinion we should allow the slogan to display incase installation profiles but remove the slogan in the Seven theme, ideally using a preprocess function instead of CSS.

@LewisNyman: What about to create an install twig template and use seven_preprocess_install_page?

Maybe we should just style the slogan correctly? I'm happy for it to show if it is somehow set, that is uncommon though.

I have added styles to tidy up the slogan within the installer.

Emma

hmm, can we change the id to a class? I don't want to create more work over on #2041793: install-page.html.twig markup and CSS

I have changed site slogan to use a class in the Twig file and amended the selectors in the installer css to reflect this.

Emma

Sorry I missed these before but:

1. +++ b/core/themes/seven/install-page.css
   @@ -89,10 +89,19 @@ body.install-page #page-title {
   +    margin: 0.75em 0 0.75em 50px; /* LTR */
   

   There are one too many indentations here.

2. +++ b/core/themes/seven/install-page.css
   @@ -89,10 +89,19 @@ body.install-page #page-title {
   +    margin: 0.75em 0 1.5em 0;
   

   If we wanted to be really efficient we could remove the last ‘0’ with the same effect.

Hey,

We're doing a Drupal 8 sprint and came across this - thought we'd make those 2 tweaks for you. Patch attached. Thanks for doing all the actual work tho :-)

Bryan

Needs a bit of work... The slogan is still to far to the left during installation. It does appear correctly once you're on the 'Configure site' page.

I've been looking at this together with @axlroach and we can only replicate the problem on the Installation profile section on his machine. Can anyone else replicate his issue? If not we're thinking it might be an odd ghost in his machine.

He did spot a missing space before a { in the CSS. Have attached a patch to correct that.

Instructions on how to test patch

Updating Issue summary By patch functionality.

Patch works as mentioned in comment #14

@shameemkm thanks. the image is not showing because of #2125301: %20 in image file names triggers the "local images only" filter

also rearranging things a bit in the issue summary

and, since there is a new patch since the last code review, and screenshot, we need to do both the manual testing and get a new screenshot, and a new code review.

for the manual testing and new screenshot, let's look especially to see if the concern from #13 (too far to the left) was addressed.
Here is the contributor task doc for adding a screenshot, if it helps https://drupal.org/node/1859584. (noticed #2132591: link to docs page (add screenshot) goes to wrong place while trying to get that link)

to make it easier to get reviews (especially re-reviews), please include interdiffs For instructions on creating an interdiff, see https://drupal.org/documentation/git/interdiff

Looks good to me aswell. Thank you very much! :)

Looks good! I was curious what this looked like even with a longer slogan and it still looks basically fine:

Committed and pushed to 8.x. Thanks!