Should not translate URL path ?

CommentFileSizeAuthor
#11 remove_t-2041321-11.patch1.08 KBoriol_e9g
#8 remove_t_2.patch1.1 KBUnitoch
remove_t.patch1.07 KBdroplet

Comments

Status: Needs review » Needs work

The last submitted patch, remove_t.patch, failed testing.

droplet’s picture

droplet commented
Status: Needs work » Needs review

remove_t.patch queued for re-testing.

oriol_e9g’s picture

oriol_e9g
Primary language Catalan
Location Barcelona
commented
Status: Needs review » Reviewed & tested by the community

Good catch!

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Will conflict with #2041287: Convert $node->nid to $node->id() and $node->isNew()

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll

Needs a reroll...

git ac https://drupal.org/files/remove_t_0.patch
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  1100  100  1100    0     0   1422      0 --:--:-- --:--:-- --:--:--  1864
error: patch failed: core/modules/dblog/lib/Drupal/dblog/Tests/DbLogTest.php:350
error: core/modules/dblog/lib/Drupal/dblog/Tests/DbLogTest.php: patch does not apply
shnark’s picture

shnark commented
Assigned: Unassigned » shnark

I'm going to reroll this, using these instructions https://drupal.org/patch/reroll

Unitoch’s picture

Unitoch commented
Assigned: shnark » Unitoch

I'm going to attempt a reroll.

Unitoch’s picture

Unitoch commented
Assigned: Unitoch » Unassigned
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new remove_t_2.patch1.1 KB

Sorry about the cross-posting, Ella!

Here's a rerolled patch.

droplet’s picture

droplet commented
Status: Needs review » Needs work 
+++ b/core/modules/dblog/lib/Drupal/dblog/Tests/DbLogTest.phpundefined
@@ -350,13 +350,13 @@ private function doNode($type) {
+    $this->assertText('node/@nid', array('@nid' => $node->id()), 'DBLog event was recorded: [page not found]');

Incorrect

droplet’s picture

droplet commented
Issue tags: +Novice, +Needs reroll

tagging

oriol_e9g’s picture

oriol_e9g
Primary language Catalan
Location Barcelona
commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new remove_t-2041321-11.patch1.08 KB
droplet’s picture

droplet commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed b4dd669 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.