Fix 'provider' keys for comment wizard default filter definitions [#2039677]

Follow-up for #1825896-42: Add module owner to plugin data on handlers

+++ b/core/modules/comment/lib/Drupal/comment/Plugin/views/wizard/Comment.php
@@ -54,12 +54,14 @@ class Comment extends WizardPluginBase {
-      'field' => 'status'
+      'field' => 'status',
+      'provider' => 'user'
...
       'field' => 'status',
+      'provider' => 'user',

This change is wrong!

Comment	File	Size	Author
#4	fix-provider-keys-for-comment-wizard-2039677-4.patch	774 bytes	lokapujya
#2	followup-2039677-2.patch	777 bytes	lokapujya

Comments

Comment #1

damiankloip commented 11 July 2013 at 12:13

Issue tags:

+Novice

tagging

Comment #2

lokapujya

English

Boston

commented 5 September 2013 at 04:05

Assigned:	Unassigned	» lokapujya
Status:	Active	» Needs review

Status	File	Size
new	followup-2039677-2.patch	777 bytes

I think we just want to change the provider to be 'comment'.

Comment #3

damiankloip commented 5 September 2013 at 07:29

Title:	Follow-up: Add module owner to plugin data on handlers	» Fix 'provider' keys for comment wizard default filter definitions
Status:	Needs review	» Needs work

Changing the title, that is just not helpful, the fact that it's a followup should not be the main point :)

Patch is looking good, but:

+++ b/core/modules/comment/lib/Drupal/comment/Plugin/views/wizard/Comment.php
@@ -55,13 +55,13 @@ class Comment extends WizardPluginBase {
     'status_node' => array(
...
+      'provider' => 'comment',

This filter handler is not provided by comment module but by node.