We have a few failures left before we can enable sqlite testing on Travis in the main repo.
For the moment there is a pull request: https://github.com/helmo/drush/pull/2

Already fixed:
#2014519: SQLite test fails due to missing path while restoring database

Open:
#2030491: quickDrupalCase::testQuickDrupal fails on PHP 5.4

Related:
#1446372: Invalid Unicode code range in PREG_CLASS_UNICODE_WORD_BOUNDARY fails with PCRE 8.30
#1542186: PHP 5.4 "Illegal string offset" warning when install
#1893612: Error during install "Warning: Illegal string offset 'field' in UpdateQuery_sqlite->removeFieldsInCondition()"

As we see many lines like these below, I would assume that we use an older version of core to test with... but that does not seem to be the case.

WD php: Warning: preg_match(): Compilation failed: disallowed Unicode  [warning]
code point (>= 0xd800 && 

WD php: Warning: Illegal string offset 'field' in                      [warning]
DatabaseCondition->__clone() (line 1734 of
/tmp/drush-sandbox/web/includes/database/query.inc).

Comments

moshe weitzman’s picture

moshe weitzman commented
Status: Active » Postponed (maintainer needs more info)

I have seen those preg warnings too but don't know why they appear ... Can we close this issue?

helmo’s picture

helmo commented

The sqlite tests are still failing for an unknown reason. So 'postponed (maintainer needs more info)' seems appropriate.

helmo’s picture

helmo commented
Status: Postponed (maintainer needs more info) » Active

Tests are now passing :)

https://travis-ci.org/helmo/drush/builds/9425372

Time to add sqlite back to the main .travis.yml?

helmo’s picture

helmo commented

I've added php 5.5 to the travis file and it all PASSES :)

https://travis-ci.org/helmo/drush/builds/9434816

moshe weitzman’s picture

moshe weitzman commented

great news about 5.5.

I actually uncommented the sqlite tests for one run at Travis. As you can see at https://travis-ci.org/drush-ops/drush/builds/9291918, that ballooned the test time to 55min, from 28 min. I'm not too comfortable with that, and I'm sure Travis would prefer if we consume fewer resources, I think we should restrict sqlite to just 5.3 or find a different way to limit the permutations for less popular DBs.

I also want to enable testing for UNISH_DRUPAL_MAJOR_VERSION=8 (and possibly D6) so we are looking at a massive explosion in permutations.

helmo’s picture

helmo commented

With three php versions it gets to 1 hr 51 min 50 sec :(, so I share your concern.

As PHP 5.3 is reaching End of Life I would suggest to default to testing on 5.4

We could keep testing of the full set in a pull request that get's rebased e.g. every week.

moshe weitzman’s picture

moshe weitzman commented

That pull request idea sounds great. As for the main repo, I think the most important permutation is for multiple versions of Drupal. When we have that on, we might go back to just one php version (I;m open to arguments for 5.4 or 5.3). We already heard about 5.3 being EOL. 5.4 is not widely used yet though.

greg.1.anderson’s picture

greg.1.anderson commented
Status: Active » Closed (won't fix)
Issue tags: +Needs migration

This issue was marked closed (won't fix) because Drush has moved to Github.

If desired, you may copy this task to our Github project and then post a link here to the new issue. Please also change the status of this issue to closed (duplicate).

Please ask support questions on Drupal Answers.

greg.1.anderson’s picture

greg.1.anderson commented
Issue summary: View changes

extra related