Part of #2017207: [meta] Complete conversion of users to Entity Field API.

CommentFileSizeAuthor
#5 user-ng-methods-2039199-5-uid-only.patch238.14 KBberdir
#5 user-ng-methods-2039199-5-uid-only-interdiff.txt1.16 KBberdir
#3 user-ng-methods-2039199-62-uid-only.patch236.98 KBberdir
#3 user-ng-methods-2039199-62-uid-only-interdiff.txt399 bytesberdir
#1 user-uid-to-methods-2039199-1.patch236.59 KBberdir

Comments

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Needs review
StatusFileSize
new user-uid-to-methods-2039199-1.patch236.59 KB

Here's the patch. This should be ready if it passes.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented

Shouldn't this also have

diff --git a/core/lib/Drupal/Core/Session/UserSession.php b/core/lib/Drupal/Core/Session/UserSession.php
index 41d55fc..b3dae61 100644
--- a/core/lib/Drupal/Core/Session/UserSession.php
+++ b/core/lib/Drupal/Core/Session/UserSession.php
@@ -19,7 +19,7 @@ class UserSession implements AccountInterface {
    *
    * @var int
    */
-  public $uid;
+  protected $uid;
 
   /**
    * Session hostname.

To be sure it passes?

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Issue tags: +sprint, +Entity Field API
StatusFileSize
new user-ng-methods-2039199-62-uid-only-interdiff.txt399 bytes
new user-ng-methods-2039199-62-uid-only.patch236.98 KB

Yes, let's do that.

Status: Needs review » Needs work

The last submitted patch, user-ng-methods-2039199-62-uid-only.patch, failed testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Needs review
StatusFileSize
new user-ng-methods-2039199-5-uid-only-interdiff.txt1.16 KB
new user-ng-methods-2039199-5-uid-only.patch238.14 KB

Hm.

japicoder’s picture

japicoder commented
Status: Needs review » Reviewed & tested by the community

Huge patch to review but I found my way to do it. I think everything is fine.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to 8.x. Thanks.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Issue tags: -sprint

Untagging.

Automatically closed -- issue fixed for 2 weeks with no activity.